Fixed the incorrect type hint for CreateStruct::$mainLocationId (#648)

For more details see #648

Key changes:

* Fixed the incorrect type hint for `CreateStruct::$mainLocationId`

* Ensured values assigned to `CreateStruct::$mainLocationId` are of the correct type

* Fixed PHPDoc of the related `Location\Gateway::create` method

* [PHPStan] Regenerated baseline after the changes

Author: alongosz

phpstan-baseline.neon

@@ -19674,12 +19674,6 @@ parameters:
 			count: 1
 			path: src/lib/Persistence/Legacy/Content/Language/MaskGenerator.php
 
-		-
-			message: '#^Method Ibexa\\Core\\Persistence\\Legacy\\Content\\Location\\Gateway\:\:create\(\) has parameter \$parentNode with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/Persistence/Legacy/Content/Location/Gateway.php
-
 		-
 			message: '#^Method Ibexa\\Core\\Persistence\\Legacy\\Content\\Location\\Gateway\:\:getBasicNodeData\(\) return type has no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue
@@ -19788,12 +19782,6 @@ parameters:
 			count: 1
 			path: src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php
 
-		-
-			message: '#^Method Ibexa\\Core\\Persistence\\Legacy\\Content\\Location\\Gateway\\DoctrineDatabase\:\:create\(\) has parameter \$parentNode with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php
-
 		-
 			message: '#^Method Ibexa\\Core\\Persistence\\Legacy\\Content\\Location\\Gateway\\DoctrineDatabase\:\:createNodeQueryBuilder\(\) has parameter \$columns with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue
@@ -19956,12 +19944,6 @@ parameters:
 			count: 8
 			path: src/lib/Persistence/Legacy/Content/Location/Gateway/ExceptionConversion.php
 
-		-
-			message: '#^Method Ibexa\\Core\\Persistence\\Legacy\\Content\\Location\\Gateway\\ExceptionConversion\:\:create\(\) has parameter \$parentNode with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/Persistence/Legacy/Content/Location/Gateway/ExceptionConversion.php
-
 		-
 			message: '#^Method Ibexa\\Core\\Persistence\\Legacy\\Content\\Location\\Gateway\\ExceptionConversion\:\:getBasicNodeData\(\) return type has no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue

src/contracts/Persistence/Content/Location/CreateStruct.php

@@ -83,7 +83,7 @@ class CreateStruct extends ValueObject
      * This is allowed to be set to true, this will mean this should become main location
      * (@todo Find a better way to deal with being able to create the main location)
      *
-     * @var mixed|true
+     * @var int|true
      */
     public $mainLocationId = true;
 

src/lib/Persistence/Legacy/Content/Location/Gateway.php

@@ -209,9 +209,9 @@ abstract public function setNodeUnhidden(string $pathString): void;
     abstract public function swap(int $locationId1, int $locationId2): bool;
 
     /**
-     * Creates a new location in given $parentNode.
+     * Creates a new location in the given `$parentNode`.
      *
-     * @param array $parentNode parent node raw data
+     * @param array<string, mixed> $parentNode parent node raw data
      */
     abstract public function create(CreateStruct $createStruct, array $parentNode): Location;
 

src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

@@ -778,7 +778,7 @@ public function create(CreateStruct $createStruct, array $parentNode): Location
     {
         $location = $this->insertLocationIntoContentTree($createStruct, $parentNode);
 
-        $mainLocationId = $createStruct->mainLocationId === true ? $location->id : $createStruct->mainLocationId;
+        $mainLocationId = $createStruct->mainLocationId === true ? $location->id : (int)$createStruct->mainLocationId;
         $location->pathString = $parentNode['path_string'] . $location->id . '/';
         $query = $this->connection->createQueryBuilder();
         $query

src/lib/Persistence/Legacy/Content/Location/Handler.php

@@ -285,7 +285,7 @@ public function copySubtree($sourceId, $destinationParentId, $newOwnerId = null)
 
             // Use content main location if already set, otherwise create location as main
             if (isset($mainLocations[$child['contentobject_id']])) {
-                $createStruct->mainLocationId = $locationMap[$mainLocations[$child['contentobject_id']]]['id'];
+                $createStruct->mainLocationId = (int)$locationMap[$mainLocations[$child['contentobject_id']]]['id'];
             } else {
                 $createStruct->mainLocationId = true;
                 $mainLocations[$child['contentobject_id']] = $child['node_id'];

src/lib/Persistence/Legacy/Content/Location/Mapper.php

@@ -89,7 +89,7 @@ public function getLocationCreateStruct(array $data)
         $struct->contentVersion = $data['contentobject_version'];
         $struct->hidden = $data['is_hidden'];
         $struct->invisible = $data['is_invisible'];
-        $struct->mainLocationId = $data['main_node_id'];
+        $struct->mainLocationId = (int)$data['main_node_id'];
         $struct->parentId = $data['parent_node_id'];
         $struct->pathIdentificationString = $data['path_identification_string'];
         $struct->priority = $data['priority'];