Fixed issues uncovered by PHPStan v2.1.23 (#649)

For more details see #649

Key changes:

* [BinaryFile Field Type] Removed redundant override of the

* [Media Field Type] Removed redundant override of the

* [Cache] Improved PersistenceLogger code quality

* [ConfigResolver] Removed redundant check if the `function` key exists

* [ViewProviders] Fixed the incorrect type hint of `Registry::$viewProviders`

* [ImageConverter] Handled possible null reference when parsing legacy XML

* [Tests] Added coverage for improved parts of PersistenceLogger

* [Tests] Fixed type hints in RelationSearchBaseIntegrationTestTrait

* [Tests] Fixed return type hints in UI Translation VOs tests

* [Country Field Type] Improved data integrity checking when converting to/from storage values

* [PHPStan] Removed resolved issues from the baseline

* [PHPStan] Regenerated baseline for PHP >= 8.0

Author: alongosz

phpstan-baseline-7.4.neon

@@ -6,24 +6,6 @@ parameters:
 			count: 1
 			path: src/bundle/Core/ApiLoader/StorageConnectionFactory.php
 
-		-
-			message: '#^Parameter \#1 \$input of function array_filter expects array, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\VersionInfo\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/bundle/Core/Command/CleanupVersionsCommand.php
-
-		-
-			message: '#^Parameter \#1 \$input of function array_slice expects array, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\VersionInfo\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/bundle/Core/Command/CleanupVersionsCommand.php
-
-		-
-			message: '#^Parameter \#1 \$var of function count expects array\|Countable, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\VersionInfo\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/bundle/Core/Command/CleanupVersionsCommand.php
-
 		-
 			message: '#^Parameter \#2 \$str of function fwrite expects string, string\|false given\.$#'
 			identifier: argument.type
@@ -198,12 +180,6 @@ parameters:
 			count: 1
 			path: src/lib/MVC/Symfony/Component/Serializer/AbstractPropertyWhitelistNormalizer.php
 
-		-
-			message: '#^Parameter \#1 \$input of function array_keys expects array, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\ContentInfo\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/lib/MVC/Symfony/FieldType/RelationList/ParameterProvider.php
-
 		-
 			message: '#^Parameter \#1 \$arr1 of function array_merge expects array, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\URLAlias\> given\.$#'
 			identifier: argument.type
@@ -246,18 +222,6 @@ parameters:
 			count: 1
 			path: src/lib/Persistence/Cache/UrlWildcardHandler.php
 
-		-
-			message: '#^Parameter \#2 \$pieces of function implode expects array, array\|bool\|float\|int\|string given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/lib/Persistence/Legacy/Content/FieldValue/Converter/CountryConverter.php
-
-		-
-			message: '#^Parameter \#2 \$pieces of function implode expects array, array\|float\|int\<min, \-1\>\|int\<1, max\>\|string\|true given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/lib/Persistence/Legacy/Content/FieldValue/Converter/CountryConverter.php
-
 		-
 			message: '#^Cannot access property \$ownerDocument on DOMElement\|false\.$#'
 			identifier: property.nonObject
@@ -360,12 +324,6 @@ parameters:
 			count: 1
 			path: src/lib/Search/Legacy/Content/Location/Gateway/CriterionHandler/Ancestor.php
 
-		-
-			message: '#^Parameter \#1 \$object of method ReflectionProperty\:\:getValue\(\) expects object, object\|null given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/bundle/Core/DependencyInjection/Compiler/SlugConverterConfigurationPassTest.php
-
 		-
 			message: '#^Parameter \#1 \$var of function count expects array\|Countable, array\|bool\|float\|int\|string\|null given\.$#'
 			identifier: argument.type
@@ -414,24 +372,6 @@ parameters:
 			count: 1
 			path: tests/integration/Core/Repository/BaseTest.php
 
-		-
-			message: '#^Parameter \#1 \$var of function count expects array\|Countable, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Relation\> given\.$#'
-			identifier: argument.type
-			count: 4
-			path: tests/integration/Core/Repository/ContentServiceAuthorizationTest.php
-
-		-
-			message: '#^Parameter \#1 \$array_arg of function usort expects TArray of array, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Relation\> given\.$#'
-			identifier: argument.type
-			count: 2
-			path: tests/integration/Core/Repository/ContentServiceTest.php
-
-		-
-			message: '#^Parameter \#1 \$input of function array_keys expects array, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\ContentInfo\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/integration/Core/Repository/ContentServiceTest.php
-
 		-
 			message: '#^Parameter \#1 \$input of function array_values expects array\<T\>, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Location\> given\.$#'
 			identifier: argument.type
@@ -450,18 +390,6 @@ parameters:
 			count: 1
 			path: tests/integration/Core/Repository/ContentServiceTest.php
 
-		-
-			message: '#^Parameter \#1 \$var of function count expects array\|Countable, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Relation\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/integration/Core/Repository/ContentServiceTest.php
-
-		-
-			message: '#^Parameter \#1 \$var of function count expects array\|Countable, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\VersionInfo\> given\.$#'
-			identifier: argument.type
-			count: 2
-			path: tests/integration/Core/Repository/ContentServiceTest.php
-
 		-
 			message: '#^Parameter \#1 \$var of function count expects array\|Countable, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\ContentType\\ContentType\> given\.$#'
 			identifier: argument.type