fix: remove deprecated findDOMNode #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that React 19 has been out for a while, we decided to upgrade, and unfortunately this is now breaking our pages. Could we get this merged soon? In the meantime, we may patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove the deprecated
findDOMNodemethod that will be removed in React 19. As far as I can see findDOMNode is designed to take class components and find the related element, butbindTotakes a reference to the element so I updated this to use the reference directly. Not sure if there are any cases where this would be insufficient.I also upgraded to React 18 for the examples.
Fixes: #91.