Fixed Offset Issues - positive/negative & hours/minutes #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iamshaunjp @pulkit2001
Fixes ISSUE #29
ISSUE WITH EARLIER CODE
The earlier code only had a provision for timezones with positive offsets and with 0 minutes offset (offset was a positive integral multiple of one hour). It would report the wrong time for zones with negative offsets by adding instead of subtracting them and also misreport time for zones whose minutes offset isn't zero (India for example)
COMMIT TO FIX
This commit creates the capability to read the sign of the offset and adds or subtracts the offset from UTC time accordingly. Also, it reads the offset in minutes and adds that along with hours to the UCT time to show the correct time for zones like India which have an offset of 5 hours 30 minutes
TEST
This commit has been tested for various time zones to ensure it doesn't fail in any and all tests have been successful.
THANK YOU