Only remove rows if deleteRowCallback doesn’t return false#237
Open
SimonSimCity wants to merge 2 commits intoiamisti:masterfrom
Open
Only remove rows if deleteRowCallback doesn’t return false#237SimonSimCity wants to merge 2 commits intoiamisti:masterfrom
false#237SimonSimCity wants to merge 2 commits intoiamisti:masterfrom
Conversation
malkomich
suggested changes
Feb 2, 2017
malkomich
left a comment
malkomich
left a comment
There was a problem hiding this comment.
I would use a promise to make some stuff asynchronously before check if deletion can be done. For example, if you want to delete from DB before removing the table entry, and when the deletion promise is well resolved you want the entry to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235
This change is