Skip to content

Refactor Nexity authentication to use inline lazy imports #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iMicknl wants to merge 2 commits into
base: v2/main
Choose a base branch
from
+20 −14
Draft

Refactor Nexity authentication to use inline lazy imports #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e84f812
Refactor Nexity authentication to load optional dependencies dynamically
iMicknl Apr 5, 2026
158f38c
Replace importlib approach with inline imports in NexityAuthStrategy.…
Copilot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions pyoverkiz/auth/strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,7 @@
from collections.abc import Mapping
from typing import Any, cast

import boto3
from aiohttp import ClientSession, FormData
from botocore.client import BaseClient
from botocore.config import Config
from botocore.exceptions import ClientError
from warrant_lite import WarrantLite

from pyoverkiz.auth.base import AuthContext, AuthStrategy
from pyoverkiz.auth.credentials import (
Expand Down Expand Up @@ -257,9 +252,20 @@ class NexityAuthStrategy(SessionLoginStrategy):

async def login(self) -> None:
"""Perform login using Nexity username and password."""
try:
import boto3
from botocore.config import Config
from botocore.exceptions import ClientError
from warrant_lite import WarrantLite
except ImportError as error:
raise NexityServiceException(
"Nexity authentication requires optional dependencies. Install with the "
"Nexity auth extras."
) from error

loop = asyncio.get_running_loop()

def _client() -> BaseClient:
def _client() -> Any:
return boto3.client(
"cognito-idp", config=Config(region_name=NEXITY_COGNITO_REGION)
)
Expand Down
16 changes: 8 additions & 8 deletions tests/test_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,12 +510,12 @@ async def test_login_maps_invalid_credentials_client_error(self):
)
warrant_instance = MagicMock()
warrant_instance.authenticate_user.side_effect = bad_credentials_error
boto3_mock = MagicMock()
boto3_mock.client.return_value = MagicMock()

with (
patch("pyoverkiz.auth.strategies.boto3.client", return_value=MagicMock()),
patch(
"pyoverkiz.auth.strategies.WarrantLite", return_value=warrant_instance
),
patch("boto3.client", boto3_mock.client),
patch("warrant_lite.WarrantLite", return_value=warrant_instance),
pytest.raises(NexityBadCredentialsException),
):
strategy = NexityAuthStrategy(
Expand All @@ -542,12 +542,12 @@ async def test_login_propagates_non_auth_client_error(self):
)
warrant_instance = MagicMock()
warrant_instance.authenticate_user.side_effect = service_error
boto3_mock = MagicMock()
boto3_mock.client.return_value = MagicMock()

with (
patch("pyoverkiz.auth.strategies.boto3.client", return_value=MagicMock()),
patch(
"pyoverkiz.auth.strategies.WarrantLite", return_value=warrant_instance
),
patch("boto3.client", boto3_mock.client),
patch("warrant_lite.WarrantLite", return_value=warrant_instance),
pytest.raises(ClientError, match="InternalErrorException"),
):
strategy = NexityAuthStrategy(
Expand Down