Open
Conversation
Contributor
ehoogerbeets
commented
Jul 28, 2025
ehoogerbeets
commented
- depends on the ilib-localedata branch to convert to jest and for the one that fixes the race condition bug
- does not need to be shipped. Only the tests were updated/modernized.
- don't need this package for packages that have already been converted to jest
- Make sure to catch exceptions when trying to reference "global" which throws on some strict platforms - Better default path using the ESM "globalThis" if everything else fails - Reorganized the tests so that browser and node based tests are in different files. That way, the browser can avoid running the node tests and node can avoid running the browser tests.
- Browsers can specify to use the webpack loader automatically by putting `"ilib-loader": "ilib-loader/browser"` in the webpack.resolve.alias in the karma configuration. - This will avoid dragging in the NodeLoader to the webpack bundle, and all of its dependencies making for a clean webpack build - reorganized the tests for Node and Browsers in separate files so that they can be excluded while running the tests for the other platform
- converted all tests - prevent running the web-only tests on node - use the new ilib-loader/browser capability to avoid dragging in NodeLoader and all its dependencies into the webpack bundle - does not need to be published, as no customer-facing code is modified - remove all traces of nodeunit
- If too much data was loaded at once, ensureLocale would sometimes have a Promise that would resolve to "true" when the data was not yet parsed and cached, leading to a situation where code would continue assuming the locale data was there. - Had to call ensureLocale with many locales hundreds of times to consistently repro the situation and show that it was fixed
🦋 Changeset detectedLatest commit: 37f2f1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- karma/web testing does not work yet, but all tests pass on node 20
- still some instability due to problems in ensureLocale in ilib-localedata
ehoogerbeets
force-pushed
the
cvtAddressToJest
branch
from
25b289b to
37f2f1d
Compare
ehoogerbeets
changed the base branch from
cvtLocaleDataToJest
to
fixEnsureLocale
ehoogerbeets
force-pushed
the
fixEnsureLocale
branch
from
eb5024a to
30ab4f9
Compare
ehoogerbeets
force-pushed
the
fixEnsureLocale
branch
from
30ab4f9 to
7d9b1e1
Compare
ehoogerbeets
force-pushed
the
fixEnsureLocale
branch
from
ee1a5f3 to
c9488d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.