Skip to content

Conversation

@gaede
Copy link
Contributor

@gaede gaede commented Sep 16, 2020

BEGINRELEASENOTES

  • set the default compression level to Z_DEFAULT_COMPRESSION (-1)
    - correct the documentation for set_level()

ENDRELEASENOTES

@rete
Copy link
Collaborator

rete commented Sep 23, 2020

TravisCI does not seem happy. Can you investigate please?

@gaede
Copy link
Contributor Author

gaede commented Sep 23, 2020

Beats me - it works on my mac with llvm and the class zlib_compression is not used at all in the relocation_read test. Could this be a problem of the CI configuration for llvm ?

@rete
Copy link
Collaborator

rete commented Sep 23, 2020

Ok, looks like we have a more general problem indeed. The CI is failing for any PR (also #5 and #3 ). I will investigate

@rete
Copy link
Collaborator

rete commented Sep 24, 2020

Beats me too... I tried different debug statements in the test code and found that adding this printout makes the test passing:

742586c#diff-4d6d06f2e0ef2a3891e972897e450f76R46

Weird...

@rete
Copy link
Collaborator

rete commented Oct 19, 2020

@gaede The travis issue has been fixed in #8 . Can you rebase please?

@gaede gaede merged commit 2a0603c into iLCSoft:master Oct 28, 2020
@gaede gaede deleted the fix_default_compression branch October 28, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants