Feat/login websso prominence#18
Open
iFadi wants to merge 5 commits into
Open
Conversation
- Redesign login template to present WebSSO as the primary action with a branded badge and descriptive hint text - Introduce a visual divider between primary and secondary login sections - Collapse ILIAS login behind a secondary toggle button with aria-expanded and aria-controls for full keyboard accessibility - Remove external jQuery CDN dependency; toggle logic rewritten in vanilla JS wrapped in an IIFE with strict mode - Replace all inline style="" attributes with semantic CSS classes - Replace display:none toggle with the HTML hidden attribute for accessible show/hide behaviour - Add rel="noopener noreferrer" to all external links - Remove Nutzungsvereinbarung (user agreement) block from login page - Rewrite _login.scss: subtler card background, flex-based nav grid, distinct primary/secondary button hierarchy, focus-visible outlines - Bump version to 1.2.0 in README and template.xml
- Center login card horizontally using flexbox on ilStartupSection - Switch nav to a single column layout so WebSSO occupies the full width - Increase WebSSO button to 18px / 18px padding with max-width 380px - Wrap secondary items (ILIAS login, info blocks) in .luh-secondary-row so they form a centered flex row beneath the divider - Add tablet breakpoint (≤720px): tighten padding, reduce column widths - Add mobile breakpoint (≤520px): stack secondary items in a single centered column, stretch buttons to full width
…rder - Revert card centering: restore margin-left: 2% and fixed 680px width - Switch nav back to left-aligned flex column (align-items: flex-start) - Revert WebSSO block to left-aligned; fix form border via !important on all three selectors to prevent ILIAS base theme from overriding it - Widen WebSSO button to 300px, 18px font, 18/28px padding - Increase block font-size to 15px, paragraph text to 13px, info links to 16px, ILIAS login button to 15px / 210px width - Tighten tablet breakpoint (≤760px) and mobile breakpoint (≤520px)
…x border - Center badge, WebSSO button and hint text within the card by switching #shib-form-login-mask to align-items: center / text-align: center and adding margin: 0 auto to #shib_login - Move Hinweise zum Login out of .luh-secondary-row into its own block after a new .luh-hint-divider (plain 1px line, same colour as the Weitere Anmeldeoptionen divider) - Broaden border: none !important rule to cover all form and .form-horizontal selectors inside #luhLogin to suppress the ILIAS base-theme border regardless of specificity
Add responsive layout, divider above Hinweise, badge/button centering, enlarged touch targets and form border fix to the v1.2.0 release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.