Add stats for nerds - #924
Open
iminsandiego wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for opening the PR! Can you perhaps run a review/sanity check on the PR before I dive into the review? Thanks! |
Author
|
Thanks for catching this. I missed running that suite before my push. I reproduced the failure and fixed it. Full Roku suite: 370/370 passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a focused Stats for Nerds overlay to VideoPlayerDev, addressing #803.
The overlay is opened from a new button in the player bar and displays:
Behavior
Implementation
Following the recommendation in #803, the overlay is implemented as a separate StatsForNerds SceneGraph component that observes the required Video fields.
Frequently changing position and duration fields are observed only while the fullscreen overlay is visible. Transient decoder information is cached so Roku fields that are exposed only briefly remain available without performing hidden label/layout updates.
Dropped frames are not included because I could not identify a reliable Roku Video field for that measurement.
Testing
Tested on a Roku Ultra with:
Screenshot