feat: add sticky per-account proxy support with VNC binding and local bypass#214
feat: add sticky per-account proxy support with VNC binding and local bypass#214MaziarAshtari wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0cad4dc574
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const rawName = typeof authData?.accountName === "string" ? authData.accountName.trim() : ""; | ||
| const key = rawName ? rawName.toLowerCase() : `auth-${authIndex}`; |
There was a problem hiding this comment.
Don't collapse non-email account labels
When two valid auth files have the same non-email accountName (for example the bundled auth saver uses "unknown" when email detection fails, or a user enters the same manual label twice), AuthSource still treats them as distinct accounts because it only canonicalizes email-looking names. This key generation collapses both to one mapping entry, so _getProxyMapping() assigns one proxy and getProxyForAuth() returns that same proxy for both accounts, breaking the promised per-account proxy isolation. Include the auth index in the key for non-email labels, or mirror AuthSource's email-only normalization.
Useful? React with 👍 / 👎.
Hi, have you ever encountered the 'queue closed' issue? |
What does this PR do?
Adds sticky per-account proxy support so each Google account always uses
the same proxy from proxylist.txt.
Features:
proxylist.txtand assigns proxies to accounts persistentlyvia
proxy_mapping.jsonuser:pass@ip:port,ip:port:user:pass,ip:port,http://user:pass@ip:port127.0.0.1, localhost, 0.0.0.0) bypass the proxyto prevent WebSocket connection failures
falling back to direct connection
STICKY_PROXY_BYPASSenvironment variableFiles changed:
src/utils/StickyProxyManager.js(new)src/core/BrowserManager.jssrc/auth/CreateAuth.jsREADME_EN.mdTested:
proxylist.txt