Skip to content

Conversation

@nicHoch
Copy link
Collaborator

@nicHoch nicHoch commented Jul 22, 2025

QL calibration spectra and sci-spectra as L2

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 16.55172% with 242 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.29%. Comparing base (3ae9671) to head (21bc36b).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
stixcore/products/level2/quicklookL2.py 5.84% 145 Missing ⚠️
stixcore/processing/FLtoL3.py 9.09% 60 Missing ⚠️
stixcore/products/level2/scienceL2.py 60.86% 9 Missing ⚠️
stixcore/products/product.py 25.00% 9 Missing ⚠️
stixcore/products/level0/scienceL0.py 0.00% 6 Missing ⚠️
stixcore/products/level1/scienceL1.py 68.42% 6 Missing ⚠️
stixcore/processing/pipeline_cron.py 0.00% 4 Missing ⚠️
stixcore/processing/LBtoL0.py 0.00% 2 Missing ⚠️
stixcore/products/__init__.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3ae9671) and HEAD (21bc36b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3ae9671) HEAD (21bc36b)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #427       +/-   ##
===========================================
- Coverage   72.23%   40.29%   -31.94%     
===========================================
  Files          78       77        -1     
  Lines        8085     8259      +174     
===========================================
- Hits         5840     3328     -2512     
- Misses       2245     4931     +2686     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +37 to +42
l2 = super().from_level1(l1product, parent=parent)[0]
l2.data['test'] = 1

# interpolate counts if RCR > 0 at any time point
if l2.data['rcr'].sum() > 0:
l2.data_corrected = l2.data[:]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samaloney here goes the count to flux conversion and lifetime correction

@samaloney samaloney mentioned this pull request Sep 30, 2025
Add support for trigger scaling in compression mode S=0,k=0,M=7 (i4Ds#377)

* Unscale data when compressed with mode S=0,k=0,M=7
* QL - LC, BKG, SPECTRA
* BSD - CPD, SCPD, VIS and SPEC

bump all product versions to 2 (i4Ds#378)

* bump all product versions to 2

* roleout IDB version 2.26.27

* fix test with new version number in mock object

* fix test

* fix for latest IDB as fallback

Fix duplicated hk time bin bug

Ddpdupdates2 (i4Ds#380)

* bump all product versions to 2

* prep for L2 ddpd

* integrate IDB release 2.26.38

* update for common CONF submodule

* fir text for latest IDB to 2.26.38

Config fix (i4Ds#381)

* bump all product versions to 2

* fix module path

Fix bugs found when processing new scaled trigger data. (i4Ds#382)

* Fix bug processing new scaled trigger data.
* Allow for QL file to unscale by packet
* Fix bug that create extra (replica) triggers in Spectrogram

Publish_L2 / RID LUT Manager (i4Ds#385)

* bump all product versions to 2
* RID LUT data manager update and use in processing for trigger descaling
* Update stixcore/io/RidLutManager.py
* fixed API mock via static files on pup99

---------

Co-authored-by: Shane Maloney <[email protected]>

Add warning if trigger scaling changes in request (i4Ds#388)

End2end rid lut manager (i4Ds#390)

* bump all product versions to 2

* add copy and parent option

* fix missing init of singleton

bump all product versions to 2 (i4Ds#389)

Bump conf version (i4Ds#391)

* bump all product versions to 2

* bump common version

Flexible way to fill DATAMAX/MIN BUNIT EXPOSURE in FITS header keywords (i4Ds#393)

* bump all product versions to 2

* add properties for dedicated fits header keywords with class inhe. / override

* add test and minor fixes after review

* fix XPOSURE/XPOMAX header error

* fix tests for dmax...

* relax end2end fitsdiff

* less tolerance in end2end test

Solo anc stix ephemeris (i4Ds#399)

* bump all product versions to 2

* add more FITS header keywords

* fix for ANC also get fits updated headers while publishing

Upgrade_watchdog (i4Ds#401)

* bump all product versions to 2

* bump version

* fix version label

* pin common CONF version for end2end test

* ignore VERS_CFG in end2end testing

* add test for TM folder observing

* bump watchdog==6.0.0

* integrate review fixes

Update docks (i4Ds#409)

* bump all product versions to 2

* update documentation

* add doc for end to end tetsing

* fix format

* add doc for manual (re)processing of fits products

E2e fix sym add (i4Ds#412)

* bump all product versions to 2

* dep np.bool8

* disable test

Get rid reason/scaling lookup error handling (i4Ds#411)

* bump all product versions to 2

* add global error detection in pipeline logger (not just main process)

* add exception handling for get_reason

daily processing pipeline (i4Ds#405)

* bump all product versions to 2

* initial

* daily processing task

* add singleStep

* move ANC-aspect from pipeline to daily_pipeline

* removed requirement for the moment

* fix i4Ds#283 and option to process only latest fits file versions

* update ddpd scripts

* fix circular imports

* test git dep

* skio test on win

* skip test on win/mac

* Update stixcore/io/FlareListManager.py

Co-authored-by: Shane Maloney <[email protected]>

* fix format error

---------

Co-authored-by: Shane Maloney <[email protected]>

Add Zenodo file (i4Ds#413)

* Add Zenodo author information

Update high resolution transmission to match IDL defaults (i4Ds#414)

Pin major and minor versions of some packages (i4Ds#415)

V1.5.1_fixes (i4Ds#420)

* bump all product versions to 2

* fix i4Ds#417

* fix  i4Ds#418

* daily report log files could have different names if the scripts run over multiple days

* fix i4Ds#419

* end2end test: better report if no corresponding file found

* rewrite pipeline to cronjob based approach i4Ds#422

* cleanup before merge

Fix bug in spectrogram time bin calculations (i4Ds#423)

* Only use the closing time offset (NIX00269) for the last science substrure

Update .zenodo.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants