Conversation
tnetennba3
approved these changes
Mar 5, 2026
Contributor
tnetennba3
left a comment
tnetennba3
left a comment
There was a problem hiding this comment.
This is much cleaner having all prompts defined in prompts.py!
Comment on lines
83
to
88
Contributor
There was a problem hiding this comment.
Tell me if this is overkill but what would be the best approach for adding static type checking such that if you pass an argument that doesn't in the prompt template or don't include an argument that's required in the template, you're informed much earlier? (E.g., in TypeScript land, I would probably define a function to generate the prompt with typed arguments.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
python is better than txt