Merged
Conversation
michaelPD-iAI
changed the title
michaelPD-iAI
force-pushed
the
refactor/get_off_langchain
branch
from
638815d to
40c427a
Compare
gecBurton
reviewed
Mar 3, 2026
evals/benchmark.py
Outdated
| return self._create_azure_llm() | ||
| case LLMProvider.LOCAI: | ||
| return self._create_locai_llm(callbacks) | ||
| return self._create_locai_llm() |
Contributor
There was a problem hiding this comment.
Suggested change
| return self._create_locai_llm() | |
| return self._create_azure_llm() |
its basically just another openai clone
gecBurton
reviewed
Mar 3, 2026
evals/benchmark.py
Outdated
| "api_version": os.getenv("OPENAI_API_VERSION", "2024-12-01-preview"), | ||
| "timeout": self.timeout, | ||
| } | ||
| def _create_azure_llm(self) -> OpenAILLM: |
Contributor
There was a problem hiding this comment.
Suggested change
| def _create_azure_llm(self) -> OpenAILLM: | |
| def _create_llm(self) -> OpenAILLM: |
you may not even need a need a function at all here now?
gecBurton
approved these changes
Mar 3, 2026
Contributor
gecBurton
left a comment
gecBurton
left a comment
There was a problem hiding this comment.
code changes look good, this should get decent test in dev before pushing to prod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto eval ran successfully: Slack
Tests all pass
Duplicated Consult pipeline docker images and ran successfully