Open
Conversation
supun-io
requested changes
Mar 2, 2026
Member
supun-io
left a comment
supun-io
left a comment
There was a problem hiding this comment.
- For all sudo objects, use SudoObjectFactory from the internal library (available from 4.0.8). See https://github.com/hyvor/internal/pull/90/changes
|
|
||
| namespace App\Api\Sudo\Object; | ||
|
|
||
| use App\Entity\Newsletter; |
| @@ -0,0 +1,38 @@ | |||
| <?php | |||
|
|
|||
| namespace App\Api\Sudo\Object; | |||
| @@ -0,0 +1 @@ | |||
| export const ssr = false; | |||
Member
There was a problem hiding this comment.
this should be added to the outest layout of sudo
| metadata: Record<string, string> | null; | ||
| }; | ||
|
|
||
| export type SudoNewsletter = { |
Member
There was a problem hiding this comment.
just Newsletter (follow the above patten)
|
|
||
| export type IssueStatus = 'draft' | 'scheduled' | 'sending' | 'sent'; | ||
|
|
||
| export type SudoIssue = { |
|
|
||
| <SplitControl label="Sending profiles"> | ||
| <span>{stats.sending_profiles_count}</span> | ||
| </SplitControl> |
Member
There was a problem hiding this comment.
Dump Object in a CodeBlock (screenshot from core sudo):
Member
There was a problem hiding this comment.
| @@ -0,0 +1 @@ | |||
| export const ssr = false; | |||
| <SplitControl label="Error (private)"> | ||
| <TextInput value={issue.error_private} disabled block /> | ||
| </SplitControl> | ||
| {/if} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #337