Skip to content

Conversation

@hyrodium
Copy link
Owner

Fix #198.

@codecov
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 84.96732% with 23 lines in your changes missing coverage. Please review.

Project coverage is 95.06%. Comparing base (61ad7eb) to head (79cb99f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/_Refinement.jl 51.61% 15 Missing ⚠️
src/_KnotVector.jl 90.74% 5 Missing ⚠️
src/_BSplineSpace.jl 90.00% 2 Missing ⚠️
src/_ChangeBasis.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   96.37%   95.06%   -1.31%     
==========================================
  Files          14       14              
  Lines        2041     2068      +27     
==========================================
- Hits         1967     1966       -1     
- Misses         74      102      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hyrodium
Copy link
Owner Author

hyrodium commented Apr 1, 2025

New features

  • clamp, clamp!, and isclamped
    • Functions for clamped B-spline spaces and B-spline manifolds.
    • These functions are not exported not to conflict with Base.
  • Base.union(k1::AbstractKnotVector, k2::AbstractKnotVector)
    • Returns k3::AbstractKnotVector, the minimum B-spline space which satisfies k1 ⊆ k3 and k2 ⊆ k3.
  • Base.:+(P1::BSplineSpace{p}, P2::BSplineSpace{p})
    • Returns P3::BSplineSpace{p}, the minimum B-spline space which satisfies P1 ⊆ P3 and P2 ⊆ P3.
  • knotvector
    • Add more methods
  • countknots
    • Add more methods
  • expand_domain
    • Experimental function without enough tests

Bug fixes

  • unique(::KnotVector)
  • ==(::BSplineManifold, ::RationalBSplineManifold)

Refactoring

  • Add missing returns
  • refinement

@hyrodium
Copy link
Owner Author

hyrodium commented Apr 1, 2025

@hyrodium hyrodium merged commit fa367af into main Apr 1, 2025
12 of 17 checks passed
@hyrodium hyrodium deleted the feature/minor_utils branch October 17, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Base.:+(::BSplineSpace, ::BSplineSpace)?

2 participants