-
Notifications
You must be signed in to change notification settings - Fork 235
Add initial CI capabilities #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Is there a way for me to take this for a test drive? Also, is there documentation for the ci.yml file that would be helpful for understanding its structure, the label names, etc.? This looks really reasonable at first glance. Thanks! |
|
Hi Rob, for a test drive, you can push to this branch and it will trigger the tests automatically (since the PR already has the "Run CI" label). I'll add a new documentation section about CI |
|
This looks good, Victor! I would like to walk through the ci.yml file in more detail before approving, because I want to understand what's going on there. Can you put a link to a github CI guide in the description (whatever resources you found helpful when you were developing this, for example)? Also, I think it would be good to have the other hypre developers take a look as well since this will affect all of them. |
|
Hi Rob, I added a new section in our rtd page about CI. Let me know if it looks good! @ulrikeyang @oseikuffuor1 @waynemitchell @liruipeng This PR is adding initial support to CI in hypre. Let me know if you have comments/feedback |
Hi Victor. I think you misunderstood my request. Sorry for not being more explicit. I was only looking for a few pointers/links in the description for this PR to help me out while I read through the I am not sure the documentation you wrote belongs in the user manual. Most of it is for developers. Developer help may be better to put on the developer wiki. The folder What you wrote should be more than sufficient for me to walk through the |
|
Oh yes, no worries! I guess we can easily move that section to the wiki page. I'm not using anything fancy in the rst file, so it's an easy switch to markdown... |
rfalgout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, Victor! The only thing I think you should do here is move the documentation to the wiki dev folder (to be added to the wiki after the merge).
Thanks, Rob! Done in 29f3028 |
This PR contains the initial steps toward implementing CI in hypre.
.github/workflows/ci.ymlthat runs on pushes tomasterand on pull requestschecktarget to CI to quickly test the compiled library.require-labeljob that fails pull requests lacking theRun CIlabel; developers must add the label to trigger the build job and unblock merging.