Enable users without passwords to delete their accounts #9827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
force-pushed
the
enable-deleting-users-without-passwords
branch
from
8a42748 to
2e58a62
Compare
seanh
commented
Aug 15, 2025
| schema = schemas.DeleteAccountSchema().bind(request=self.request) | ||
| @property | ||
| def form(self): | ||
| if self._form: # pragma: no cover |
There was a problem hiding this comment.
The way this legacy Deform/Colander forms stuff works with instantiating schemas and then binding them to the request and then using request.create_form() and handle_form_submission() is just a nightmare for testability. This # pragma: no cover here was my concession to practicality. The form has to be cached on self._form, otherwise rendering of validation errors breaks.
seanh
commented
Aug 15, 2025
Comment on lines
562
to
+567
|
|
||
| def test_it_with_no_csrf_token(self, schema, pyramid_csrf_request): | ||
| del pyramid_csrf_request.headers["X-CSRF-Token"] | ||
|
|
||
| with pytest.raises(BadCSRFToken): | ||
| schema.deserialize({"password": "test_password"}) |
There was a problem hiding this comment.
Added this missing test for DeleteAccountSchema.
robertknight
approved these changes
Aug 18, 2025
| @@ -293,6 +293,22 @@ def validator(self, node, value): | |||
| raise exc | |||
|
|
|||
|
|
|||
| class DeleteAccountSchemaNoPassword(CSRFSchema): | |||
| username = colander.SchemaNode( | |||
| colander.String(), title=_("Confirm your username to delete your account") | |||
There was a problem hiding this comment.
I wondered about the phrasing here. GitHub uses "Type {text} to confirm" in its confirmation dialogs for dangerous actions, which is slightly more direct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
devdata_user), go to http://localhost:5000/account/delete, and you'll have to confirm your password to delete your account.