fix: num64 == "long" generates broken helper files#844
Open
ahm23 wants to merge 1 commit intohyperweb-io:mainfrom
Open
fix: num64 == "long" generates broken helper files#844ahm23 wants to merge 1 commit intohyperweb-io:mainfrom
ahm23 wants to merge 1 commit intohyperweb-io:mainfrom
Conversation
…sing binary reader/writer imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configured to use
Longfor 64-bit numbers instead ofbigint, certain helper files likehelper-func-types.tsare still being generated to import./binaryand useBinaryReader/BinaryWriterfor param type definitions, where they shouldn't be.src/types/binary.ts,src/types/utf8.ts, andsrc/types/varint.tsare not even generated when configured to useLongfor 64-bit numbers, so while it's not only incorrect, it also causes build issues in packages importing a package generated using telescope because of the missing imports.This change makes the helper templates use the right encoding/decoding mechanisms, and removes broken imports: