Conversation
feat(cosmos): propagate `$chain.env` when calling scripts
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges the v1 branch into main, retaining both Helm charts and the generator in main while keeping v1 active for ongoing syncs.
- Add shared environment variable includes via two helper templates
- Remove inline environment loops in multiple chain templates
- Bump chart version and expand GitHub workflows to watch the
v1branch
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| charts/devnet/templates/chains/cosmos/validator.yaml | Include defaultEvnVars/evnVars and clean up old loops |
| charts/devnet/templates/chains/cosmos/genesis.yaml | Same environment include adjustments for genesis |
| charts/devnet/templates/_helpers.tpl | Define new devnet.evnVars helper |
| charts/devnet/Chart.yaml | Bump chart version from 1.8.0 to 1.8.1 |
| .github/workflows/* | Add v1 branch to PR triggers in all workflows |
Comments suppressed due to low confidence (2)
starship/charts/devnet/templates/chains/cosmos/validator.yaml:157
- [nitpick] This
echoprints only a blank line and may have been left in by mistake; consider removing it or adding a descriptive message.
echo
starship/charts/devnet/templates/chains/cosmos/validator.yaml:60
- [nitpick] You repeat the
defaultEvnVarsandevnVarsincludes in multiple templates; consider creating a single wrapper helper that inlines both to reduce duplication.
{{ include "devnet.defaultEvnVars" $chain | indent 12 }}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feature: ingress grpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge v1 into main, we can keep both the helm charts and the generator in main at the same time.
We will additionally keep the v1 branch active and keep merging from time to time.