Open
Conversation
Collaborator
Author
|
cc @Anmol1696 this is from Codex |
Anmol1696
requested changes
May 23, 2025
Collaborator
Anmol1696
left a comment
Anmol1696
left a comment
There was a problem hiding this comment.
Some other notes:
- need to add tests
- multi-validator setup not supported (okish for now)
| - --suggested-fee-recipient=0x0C46c2cAFE097b4f7e1BB868B89e5697eE65f934 | ||
|
|
||
| bitcoin: | ||
| image: ruimarinho/bitcoin-core:latest |
Collaborator
There was a problem hiding this comment.
This seems to be just a random docker image, and seems to be outdated.
| app.kubernetes.io/type: {{ $chain.id }} | ||
| spec: | ||
| containers: | ||
| - name: bitcoind |
Collaborator
There was a problem hiding this comment.
We also need some init containers so that the btc nodes are more configureable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test ./...(fails: directory prefix does not contain main module)