Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds ingress verification support by extending URL construction utilities, updating existing verifiers to accept configuration and handle ingress, and integrating new ingress checks into the main verify flow.
- Introduce
getServiceUrlhelper for consistent base URL and path resolution (including ingress) - Extend all existing verifiers to accept
StarshipConfigand use error handling helper - Add
ingress.tswith per-service ingress health checks and integrate intoverify - Update config schema and tests to enable and cover ingress scenarios
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| clients/js/packages/client/src/verifiers/utils.ts | Add getServiceUrl util and ServiceUrl interface |
| clients/js/packages/client/src/verifiers/types.ts | Extend verifier function types to accept config; add error helper |
| clients/js/packages/client/src/verifiers/relayer.ts | Update relayer verifiers to use getServiceUrl and accept config |
| clients/js/packages/client/src/verifiers/registry.ts | Update registry verifier to use getServiceUrl and improved error paths |
| clients/js/packages/client/src/verifiers/explorer.ts | Update explorer verifier to accept config and use getServiceUrl |
| clients/js/packages/client/src/verifiers/chain.ts | Update chain verifiers to use getServiceUrl, accept config, and granular error handling |
| clients/js/packages/client/src/verifiers/ingress.ts | New file: implements ingress-specific health checks for all services |
| clients/js/packages/client/src/verifiers/index.ts | Integrate verifyIngress into the main verification pipeline |
| clients/js/packages/client/src/config.ts | Make Ingress.host required and tighten schema |
| clients/js/packages/client/tests/client.verify.test.ts | Add tests for ingress success and failure scenarios |
Comments suppressed due to low confidence (2)
clients/js/packages/client/src/verifiers/explorer.ts:12
- [nitpick] Using
'http'as the endpoint identifier for the explorer verifier deviates from the'rest'convention used by other services. Consider aligning this to'rest'or documenting the distinction to avoid confusion.
endpoint: 'http',
clients/js/packages/client/tests/client.verify.test.ts:241
- The ingress tests mock chain REST, RPC, registry, and explorer URLs but omit mocks for chain faucet and exposer. Without them, unhandled URLs will throw errors. Add mocks for those endpoints to fully cover ingress verification.
mockedAxios.get.mockImplementation((url) => {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.