Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the version numbers across the repository to 3.7.0 to maintain consistency and simplify version management.
- Updated Chart.yaml to reflect the new version.
- Introduced a version synchronization script (sync-version.sh) that updates version strings in various files.
- Updated package.json files and added a VERSION file with the unified version.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| starship/charts/devnet/Chart.yaml | Updated chart version to 3.7.0. |
| scripts/sync-version.sh | Added a script to sync version numbers across files. |
| clients/js/packages/starshipjs/package.json | Updated package version to 3.7.0. |
| clients/js/package.json | Updated version and modified publish commands for consistency. |
| VERSION | Introduced VERSION file with version 3.7.0. |
Comment on lines
+16
to
+26
| # Update Chart.yaml | ||
| echo "Updating Chart.yaml..." | ||
| sed -i '' "s/^version: .*/version: $version/" starship/charts/devnet/Chart.yaml | ||
|
|
||
| # Update root package.json | ||
| echo "Updating root package.json..." | ||
| sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" clients/js/package.json | ||
|
|
||
| # Update all package.json files in packages | ||
| echo "Updating package.json files in packages..." | ||
| find clients/js/packages -name "package.json" -exec sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" {} \; |
There was a problem hiding this comment.
The in-place sed command using 'sed -i ''' may work on macOS but can cause issues on Linux (GNU sed) which uses a different syntax. Consider adding conditional handling or documentation to ensure cross-platform compatibility.
Suggested change
| # Update Chart.yaml | |
| echo "Updating Chart.yaml..." | |
| sed -i '' "s/^version: .*/version: $version/" starship/charts/devnet/Chart.yaml | |
| # Update root package.json | |
| echo "Updating root package.json..." | |
| sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" clients/js/package.json | |
| # Update all package.json files in packages | |
| echo "Updating package.json files in packages..." | |
| find clients/js/packages -name "package.json" -exec sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" {} \; | |
| # Detect OS and set sed command | |
| local sed_command | |
| if [[ "$(uname)" == "Darwin" ]]; then | |
| sed_command="sed -i ''" | |
| else | |
| sed_command="sed -i" | |
| fi | |
| # Update Chart.yaml | |
| echo "Updating Chart.yaml..." | |
| $sed_command "s/^version: .*/version: $version/" starship/charts/devnet/Chart.yaml | |
| # Update root package.json | |
| echo "Updating root package.json..." | |
| $sed_command "s/\"version\": \".*\"/\"version\": \"$version\"/" clients/js/package.json | |
| # Update all package.json files in packages | |
| echo "Updating package.json files in packages..." | |
| find clients/js/packages -name "package.json" -exec $sed_command "s/\"version\": \".*\"/\"version\": \"$version\"/" {} \; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.