Skip to content

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jul 19, 2025

The PR for hyperspy/hyperspy#3528. These changes are compatible with the release and development version of hyperspy.

Progress of the PR

  • Update reference metadata dictionary to support changes in #3528,
  • Handle deprecation of reader and extension parameters in the test suite,
  • update docstring: replace mentions of reader argument,
  • update user guide: replace mentions of reader argument,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • update tests,
  • ready for review.

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.03%. Comparing base (c4aa0b1) to head (73e8a77).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rsciio/emd/_api.py 14.28% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   88.02%   88.03%           
=======================================
  Files          91       91           
  Lines       11538    11547    +9     
  Branches     2131     2135    +4     
=======================================
+ Hits        10156    10165    +9     
+ Misses        875      872    -3     
- Partials      507      510    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericpre ericpre changed the title File format and use new FileIO hyperspy metadata Use file_format and use new FileIO hyperspy metadata Jul 19, 2025
@ericpre
Copy link
Member Author

ericpre commented Jul 19, 2025

The failure on the development branch of hyperspy is fixed in hyperspy/hyperspy#3528.

@jlaehne jlaehne mentioned this pull request Jul 24, 2025
4 tasks
@ericpre ericpre mentioned this pull request Jul 25, 2025
@jlaehne
Copy link
Member

jlaehne commented Jul 25, 2025

Note that a number of user guide pages and docstrings mention the reader argument and need to be adapted once this is released on the HyperSpy side!

@ericpre ericpre added this to the v0.11 milestone Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants