Trim Hypervisor trait
#924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
vm_trait_new
branch
3 times, most recently
from
81f0d54 to
62fad87
Compare
ludfjig
added
the
kind/refactor
ludfjig
force-pushed
the
vm_trait_new
branch
17 times, most recently
from
1562f26 to
edc7f00
Compare
ludfjig
force-pushed
the
vm_trait_new
branch
4 times, most recently
from
f6337f9 to
350b8e0
Compare
jsturtevant
reviewed
Dec 4, 2025
simongdavies
requested changes
Dec 4, 2025
dblnz
reviewed
Dec 5, 2025
Contributor
There was a problem hiding this comment.
Awesome work! A lot of duplicated code removal and overall clearer design.
I've left some small comments, with questions mostly, but otherwise from my point of view it's good to go.
edit: I've reviewed each commit, some comments might not be up-to-date with the latest version
jprendes
reviewed
Dec 5, 2025
Contributor
jprendes
left a comment
jprendes
left a comment
There was a problem hiding this comment.
I haven't finished yet, but these are my comments so far
Love this refactor, long overdue! :-)
ludfjig
force-pushed
the
vm_trait_new
branch
3 times, most recently
from
22458cb to
34950f8
Compare
simongdavies
approved these changes
Dec 8, 2025
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]> impl debuggablevm Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Hypervisortrait. It's now a minimal trait for common functionality of a minimal Vm. It abstracts over differences in kvm, mshv, whp. This traits only knows things like set/get registers, run, but nothing about guest functions or hyperlight specifics.HyperlightVmstruct. This is a new struct that contains thedyn Hypervisorabove, as well as things like guest_ptr, rsp, memory-regions, gdb connections, etc. HyperlightVm knows about initialization, dispatching guest calls, gdb-debugging etc, guest-tracing, whichHypervisortrait doesn't. All code that was previously duplicated in kvm/mshv/whp now lives in HyperlightVm.Please review PR commit-by-commit. Because most code changes are just moves, I've done a compromise where I split up work in atomic commits, however each commit may not compile. I think this still useful because it will be easier to review. I plan on squashing this PR when done.
Closes #465, #904