-
Notifications
You must be signed in to change notification settings - Fork 139
Add memory mapping support with KVM #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tried making the test a bit more complex, where the guest tries to access an mmap buffer that hasn't been mapped by the host. Subsequent call (a simple PrintOutput call in this case) fails with
I think there must be some sandbox state we aren't correctly restoring after a guest call fails with certain modes. |
07a0e93
to
b7adcf4
Compare
Signed-off-by: Jorge Prendes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds memory mapping with KVM.
This means that we are now only missing support for memory mapping on Windows.
It also adds a smoke test for the supported platforms.