fix(windows): prevent WHvDeletePartition race #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HvDeletePartition kill() could call WHvCancelRunVirtualProcessor while WhpVm::drop() was calling WHvDeletePartition, causing use-after-free crashes (STATUS_ACCESS_VIOLATION or STATUS_HEAP_CORRUPTION). Fix by protecting the partition handle with an RwLock. kill() takes a read lock, and set_dropped() takes a write lock to block until all in-flight cancel calls complete before the partition is deleted. Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
windows_reporo
branch
from
07076ff to
cc37df6
Compare
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
simongdavies
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent race between WHvCancelRunVirtualProcessor and WHvDeletePartition
kill() could call WHvCancelRunVirtualProcessor while WhpVm::drop() was calling WHvDeletePartition, causing use-after-free crashes (STATUS_ACCESS_VIOLATION or STATUS_HEAP_CORRUPTION).
Fix by protecting the partition handle with an RwLock. kill() takes a read lock, and set_dropped() takes a write lock to block until all in-flight cancel calls complete before the partition is deleted.