Make mem::exe::LoadInfo a struct, instead of an alias #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
kind/enhancement
simongdavies
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
7 tasks
simongdavies
force-pushed
the
update-loadinfo
branch
from
9fa0137 to
132564f
Compare
This has the major advantage that it makes it easy to impl Clone on the struct, which will be useful shortly when snapshots start to keep copies of the load info around. Signed-off-by: Simon Davies <[email protected]>
simongdavies
force-pushed
the
update-loadinfo
branch
from
132564f to
dec31c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the major advantage that it makes it easy to impl Clone on the struct, which will be useful shortly when snapshots start to keep copies of the load info around.