Build block before importing it in reference tests #9256
+290
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirgee
force-pushed
the
build-block-before-import-in-ref-tests-main
branch
3 times, most recently
from
d5cb433 to
67a9b7f
Compare
matkt
reviewed
Oct 1, 2025
| "frontier", | ||
| "frontiertohomesteadat5", | ||
| "homestead", | ||
| "homesteartoeip150at5", |
Signed-off-by: Miroslav Kovar <[email protected]>
mirgee
force-pushed
the
build-block-before-import-in-ref-tests-main
branch
from
67a9b7f to
865be7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For forks which support block building, build block using
MergeBlockCreatorfrom the data in the fixture and import it.The import path remains unchanged - if a block is built, it is asserted that it is equivalent to the candidate block created directly from the fixture before importing it.
With these changes, the reference tests exercise block building logic. This is especially useful for verifying that BAL constructed during block creation is equivalent to the BAL constructed during block import.