Skip to content

splice-validator: make sure users (which are OIDC sub values) are quo… #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SLoeuillet
Copy link

…ted because Okta uses emails and '@' breaks yaml file loading if not quoted

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

…ted because Okta uses emails and '@' breaks yaml file loading if not quoted
@giner
Copy link
Contributor

giner commented Jun 4, 2025

Nice. Thank you!

Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Please include [static] in your commit message to trigger CI. no longer necessary

@moritzkiefer-da
Copy link
Contributor

you're also missing the git signoff message

@moritzkiefer-da
Copy link
Contributor

@SLoeuillet ping, you still need to fix the signoff for us to be able to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants