Fix versions after 0.5.0 cut #3133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See DACH-NY/canton-network-internal#2535 (preparing the PR a bit earlier than usual, because it's late) [ci] Signed-off-by: Martin Florian <[email protected]>
Contributor
Author
I hoped that this could work earlier, but I was wrong... Rerunning CI once we have that branch should be enough 🤞 |
Contributor
Author
|
I'm a bit confused at this point by what we want CI to test here w.r.t. upgrading, but also see no reason why anything could be broken. |
martinflorian-da
requested review from
moritzkiefer-da and
nicu-da
and removed request for
moritzkiefer-da
nicu-da
approved these changes
Nov 7, 2025
moritzkiefer-da
approved these changes
Nov 7, 2025
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
probably also nede to reenable ciupgrade?
Contributor
Author
yup it's tracked already on https://github.com/DACH-NY/canton-network-internal/issues/2535 can wait until Monday IMHO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/DACH-NY/canton-network-internal/issues/2535
(preparing the PR a bit earlier than usual, because it's late)
[ci]
Signed-off-by: Martin Florian [email protected]