Rotate OTK keys with missing signatures #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julientinguely-da
force-pushed
the
julien/357-security-clean-otk-mappings
branch
from
d398309 to
0eb0d98
Compare
julientinguely-da
force-pushed
the
julien/357-security-clean-otk-mappings
branch
from
47db40b to
0c9c98a
Compare
Signed-off-by: Julien Tinguely <[email protected]>
julientinguely-da
force-pushed
the
julien/357-security-clean-otk-mappings
branch
from
002563f to
56e0123
Compare
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Contributor
Author
|
/hdm_test |
|
Deploy HDM pipeline triggered for Commit cea9a8d4d951fcbc09faeb537a60950d951d23ac in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/34178 |
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Nice work! Overall looks very sensible but needs a bit of cleanup imho.
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Show resolved
Hide resolved
...ain/scala/org/lfdecentralizedtrust/splice/sv/onboarding/joining/JoiningNodeInitializer.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Julien Tinguely <[email protected]>
julientinguely-da
force-pushed
the
julien/357-security-clean-otk-mappings
branch
from
5db6d09 to
f8e75e9
Compare
Signed-off-by: Julien Tinguely <[email protected]>
…ulien/357-security-clean-otk-mappings
moritzkiefer-da
approved these changes
Oct 10, 2025
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
very nice! Changes look great to me, as discussed let's still not merge for now
| } | ||
|
|
||
| "rotate SV' OTK mapping keys that are not signed." in { implicit env => | ||
| clue("sv1 starts.") { |
Contributor
There was a problem hiding this comment.
probably wanna check first that the keys are wrong before you start the appss
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/setup/NodeInitializer.scala
Outdated
Show resolved
Hide resolved
…ulien/357-security-clean-otk-mappings
…/357-security-clean-otk-mappings
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Moritz Kiefer <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Contributor
Author
|
/cluster_test |
|
Deploy cluster test triggered for Commit d929d2e0a66a139e93cbf667398f0e78a9f3e807 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/39308 |
…ulien/357-security-clean-otk-mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/DACH-NY/canton-network-internal/issues/357
explicitly not adding a release note for this one
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines