Skip to content

Add more context and links to app dev docs #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

meiersi-da
Copy link

@meiersi-da meiersi-da commented Jun 17, 2025

@ray-roestenburg-da @hrischuk-da: could I ask you for a review please :)

I suggest building the docs locally to review them more easily:

cd docs
./livepreview.sh

TODO:

  • add an entry to the release notes

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@meiersi-da meiersi-da force-pushed the meiersi/tie-app-dev-docs-to-da-docs branch from 9b8b372 to 7d054cd Compare June 24, 2025 13:54
@meiersi-da meiersi-da changed the title WIP: add more context and links to app dev docs Add more context and links to app dev docs Jun 24, 2025
@meiersi-da meiersi-da marked this pull request as ready for review June 24, 2025 13:59
@meiersi-da meiersi-da force-pushed the meiersi/tie-app-dev-docs-to-da-docs branch 3 times, most recently from d2d50fd to 2e6d4dc Compare June 24, 2025 15:08
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks for cleaning this up!

@meiersi-da meiersi-da force-pushed the meiersi/tie-app-dev-docs-to-da-docs branch from 7052a69 to 412ccb3 Compare June 25, 2025 11:46
Copy link
Contributor

@ray-roestenburg-da ray-roestenburg-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! some minor suggestions.

@meiersi-da meiersi-da force-pushed the meiersi/tie-app-dev-docs-to-da-docs branch from a2ca638 to 98b56d4 Compare June 25, 2025 12:48
meiersi-da and others added 5 commits June 25, 2025 14:12
- improve ToC and contextualize the different APIs
- link to Digital Asset docs for CN app dev
- clarify version information and SDK installation

[ci]

Signed-off-by: Simon Meier <[email protected]>
Co-authored-by: moritzkiefer-da <[email protected]>
Signed-off-by: Simon Meier <[email protected]>
[ci]

Signed-off-by: Simon Meier <[email protected]>
[no ci]

Co-authored-by: Raymond Roestenburg <[email protected]>
Signed-off-by: Simon Meier <[email protected]>
Signed-off-by: Simon Meier <[email protected]>
@meiersi-da meiersi-da force-pushed the meiersi/tie-app-dev-docs-to-da-docs branch from 98b56d4 to 61ec515 Compare June 25, 2025 14:12

.. image:: ../../validator_operator/images/validator-network-diagram.png
:width: 600
:alt: Validator Network Diagram

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the "Validator Network Diagram" is sufficient. The VND is an infrastructure diagram. It doesn't describe the software architecture and the API endpoints. I realized this when I asked "Where is the application?" in the picture that is about "how to deploy a validator using Helm charts." I have a very high conviction that this is needed.

- use the token standard
- mention the `AppPaymentRequestFlow` as deprecated
- clearly mark splice subscription API as deprecated
Splice defines Daml APIs that decouple different applications on the Canton Network.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this sentence confusing: "Splice defines Daml APIs that decouple different applications on the Canton Network."

My mental model is that "Splice includes interoperability standards that are intended to reduce coupling between applications. These standards and reference implementations are provided as Daml models."

I find the decoupling is a secondary aspect that is an intended side-effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants