Switch to new ACS export/import endpoints #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzkiefer-da
force-pushed
the
cocreature/import-acs
branch
2 times, most recently
from
61c46f0 to
9dd6fb3
Compare
moritzkiefer-da
force-pushed
the
cocreature/import-acs
branch
2 times, most recently
from
5e4f28d to
df03b3a
Compare
[ci] This breaks cross-version compatibility in a few ways: 1. Sponsor SV needs to be on same version as the candidate. 2. For recover from key scan needs to be on the same version as the validator. 3. A HSM export needs to happen on the same version as the import. 1 and 2 don't seem problematic to me. 3 is a bit more problematic. In particular, we need to avoid merging this while we might still want to cut a new 3.x release that we upgrade testnet or mainnet to directly and even afterwards there may be stragglers. We can either tell people they need to upgrade to 0.4.1 first to complete the HDM which sounds fairly reasonable or we opt for the safer option of waiting for 30 days after the HDM is complete because then they would be pruned away anyway. Signed-off-by: Moritz Kiefer <[email protected]>
[ci] Signed-off-by: Moritz Kiefer <[email protected]>
[ci] Signed-off-by: Moritz Kiefer <[email protected]>
moritzkiefer-da
force-pushed
the
cocreature/import-acs
branch
from
df03b3a to
f97b33c
Compare
moritzkiefer-da
commented
Jun 30, 2025
| show"Download ACS snapshot for DSO at $authorizedAt", | ||
| participantAdminConnection | ||
| .downloadAcsSnapshot( | ||
| .downloadAcsSnapshotForPartyMigration( |
Contributor
Author
There was a problem hiding this comment.
the new endpoint handles that correctly without the crap here
moritzkiefer-da
pushed a commit
that referenced
this pull request
Jul 1, 2025
[ci] This reverts commit a9aa5b8. blows up on cilr because it's too slow Signed-off-by: Moritz Kiefer <[email protected]>
moritzkiefer-da
added a commit
that referenced
this pull request
Jul 1, 2025
* Revert "Switch to new ACS export/import endpoints (#1021)" [ci] This reverts commit a9aa5b8. blows up on cilr because it's too slow Signed-off-by: Moritz Kiefer <[email protected]> * Revert "Bump base version for ciperiodic migration tests (#1268)" [ci] This reverts commit 63fc1ef. Signed-off-by: Moritz Kiefer <[email protected]> --------- Signed-off-by: Moritz Kiefer <[email protected]> Co-authored-by: Moritz Kiefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci]
This breaks cross-version compatibility in a few ways:
1 and 2 don't seem problematic to me. 3 doesn't matter now that mainnet is upgraded.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines