Test WalletStore queries #1108
Open
Test WalletStore queries #1108
+210
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrosfilios
requested changes
Jun 10, 2025
|
|
||
| Expect(mockDB.ExpectationsWereMet()).To(Succeed()) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| Expect(actualWalletIDs[0]).To(Equal(output)) |
|
|
||
| Expect(mockDB.ExpectationsWereMet()).To(Succeed()) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| Expect(exists).To(Equal(true)) |
| func mockWalletStore(db *sql.DB) *common.WalletStore { | ||
| store, _ := common.NewWalletStore(db, db, common.TableNames{ | ||
| Wallets: "WALLETS", | ||
| }, sqlite.NewConditionInterpreter()) |
There was a problem hiding this comment.
done.
actually changed this to
func mockWalletStore(db *sql.DB) *WalletStore {
which directs to postgres.WalletStore.
Also moved the tests to sqlite and postgres dirs.
There was a problem hiding this comment.
I didn't understand the comment before. Now fixed.
done.
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
Signed-off-by: ADIR <[email protected]>
aaadir
force-pushed
the
test_wallet_store_queries
branch
from
bb3fbdb to
87ff6f9
Compare
Signed-off-by: ADIR <[email protected]>
alexandrosfilios
requested changes
Jun 19, 2025
| "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| type storeConstructor func(*sql.DB) *WalletStore |
There was a problem hiding this comment.
that's going to create conflicts when you push your other PR's. you will have clashing type names
Signed-off-by: ADIR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.