Skip to content
This repository was archived by the owner on Jan 27, 2022. It is now read-only.

Implemented Key Sharing and Seperation Config id Feature for Singleton. #731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karthikamurthy
Copy link
Contributor

Signed-off-by: Karthika Murthy [email protected]

@lgtm-com
Copy link

lgtm-com bot commented Dec 12, 2020

This pull request introduces 1 alert when merging 4da1c5b into 235402f - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request introduces 1 alert when merging b58aafc into 235402f - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request introduces 1 alert when merging b068c59 into 235402f - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2020

This pull request introduces 1 alert when merging 5f421ba into 235402f - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2020

This pull request introduces 4 alerts when merging 8962aaa into 235402f - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Mismatch between signature and use of an overriding method
  • 1 for Wrong number of arguments in a call
  • 1 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request introduces 2 alerts when merging fed2b31 into 235402f - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call
  • 1 for Wrong number of arguments in a class instantiation

if not self._epid_enclave_info:
self._epid_enclave_info = self.enclave_info.EpidEnclaveInfo(
if self._config.get("kss_config") is not None:
logger.info("KSS Config: " + self._config.get("kss_config"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to display kss_config in log?


logger = logging.getLogger(__name__)


class KeyManagementEnclaveInfo(BaseEnclaveInfo):
class KeyManagementEnclaveInfo(enclave_info.BaseEnclaveInfo):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message says config id feature for singleton but KME is also touched. Change commit message accordingly.

"""
KME info class to initialize enclave, signup enclave and hold
data obtained post signup.
"""

# -------------------------------------------------------
def __init__(self, config, worker_id, enlcave_type):
def __init__(self, config, worker_id):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason why enclave_type is removed?

Returns :
@returns signup_info_obj - Signup info data
"""

# Part of what is returned with the signup data is an enclave quote, we
# want to update the revocation list first.
self._update_sig_rl()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is specific epid attestation and it is moved to epid file , usage should go that file

@@ -147,7 +157,9 @@ namespace tcf {

// First attempt to load the enclave executable
sgx_status_t ret = SGX_SUCCESS;
ret = tcf::sgx_util::CallSgx([this, flags, &token] () {
if(this->_kss_config[0] == NULL){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we checking only index 0, is that sufficient?


} else {
tcf::Log(TCF_LOG_INFO, "Enclave::sgx_create_enclave_ex called" );
void *enclave_ex_p[32] = { 0 };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constant instead of hard coded value 32, may be sgx sdk or create one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants