Skip to content

Salience over flow #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newm4n merged 3 commits into from
Jul 4, 2025
Merged

Salience over flow #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f68bc41
Increased some version stated in the docs to better reflect current v…
Jul 4, 2025
55b51cd
Add some overflow protection when setting salience
Jul 4, 2025
efb44af
Merge branch 'master' into salienceOverFlow
newm4n Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ A clear and concise description of what the bug is.
Steps to reproduce the behavior:
1. I create code for this and that
2. With a test for this and that
3. Instead of seeng this
3. Instead of seeing this
4. I see that

**Expected behavior**
Expand Down
8 changes: 7 additions & 1 deletion ast/Salience.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

package ast

import "math"

// NewSalience create new Salience AST object
func NewSalience(val int) *Salience {

Expand All @@ -34,5 +36,9 @@ type SalienceReceiver interface {

// AcceptIntegerLiteral accept the assigned integer
func (sal *Salience) AcceptIntegerLiteral(lit *IntegerLiteral) {
sal.SalienceValue = int(lit.Integer)
if lit.Integer >= math.MinInt32 && lit.Integer <= math.MaxInt32 {
sal.SalienceValue = int(lit.Integer)
} else {
panic("Salience value out of range")
}
}
Loading