Skip to content

Upgrade ANTLR4 to 4.13.1#470

Merged
newm4n merged 8 commits intohyperjumptech:masterfrom
max-co:feature/antlr-4.13
Jun 30, 2025
Merged

Upgrade ANTLR4 to 4.13.1#470
newm4n merged 8 commits intohyperjumptech:masterfrom
max-co:feature/antlr-4.13

Conversation

@max-co
Copy link
Copy Markdown
Contributor

@max-co max-co commented Dec 17, 2024

This PR brings the upgrade of ANTLR4 to version v4.13.0.
The upgrading of the ANTLR4 dependency was previously discussed in #360.

The release notes of v4.13.0 cite improvements, in particular, for the Go implementation.

Additional information:

  • versions newer than v4.13.0 require Go 1.22
  • the code for Go (generated in the directory 'antlr/parser/grulev3') is the same between ANTLR4's v4.13.0 and v4.13.2 JARs

@newm4n
Copy link
Copy Markdown
Collaborator

newm4n commented Jun 29, 2025

After fighting with my sickness, Im ready continue on and return to accepting changes. Im sorry for this and thank you for your contribution.
Could you resolve the conflict before I can merge them In. Thanks

@max-co
Copy link
Copy Markdown
Contributor Author

max-co commented Jun 29, 2025

I am sorry to hear that you were unwell, I give you blessings for your well-being.

Thank you for looking at this PR.
I have resolved the merge conflicts.
Also, as now Grule is using Go 1.24, I took the liberty of updating ANTLR4 to v4.13.1 (which requires Go 1.22 or higher).

@max-co max-co changed the title Upgrade ANTLR4 to 4.13.0 Upgrade ANTLR4 to 4.13.1 Jun 29, 2025
Copy link
Copy Markdown
Collaborator

@newm4n newm4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great length of contribution.

@newm4n newm4n merged commit ca6b212 into hyperjumptech:master Jun 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants