Skip to content

Removing Firefox exceptions from hyper backend #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neborn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing Firefox exceptions from hyper backend #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions services/hyper-backend-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ pkg.value('hyperHttpRefreshHeaders', [
'content-location'
]);

/**
* Firefox is the worst
*/

var isFirefox = !!~window.navigator.userAgent.indexOf('Firefox');

/**
* hyper backend http service
*/
Expand Down Expand Up @@ -97,17 +91,17 @@ pkg.factory('hyperBackend', [

if (method === 'GET') return;

if (!disableRefresh) emitter.refresh(action, !isFirefox);
if (!disableRefresh) emitter.refresh(action);
angular.forEach(refreshHeaders, function(header) {
var href = headers(header);
if (href) emitter.refresh(href, !isFirefox);
if (href) emitter.refresh(href);
});

// http://tools.ietf.org/html/draft-nottingham-linked-cache-inv-03#section-3
var invalidates = links.invalidates;
invalidates = typeof invalidates === 'string' ? [invalidates] : invalidates;
angular.forEach(invalidates || [], function(href) {
emitter.refresh(href, !isFirefox);
emitter.refresh(href);
});
})
.error(function(err) {
Expand Down Expand Up @@ -143,7 +137,7 @@ pkg.factory('hyperHttpEmitter', [
};
};

emitter.refresh = function (href, shouldNotify) {
emitter.refresh = function (href) {
if (!cache) cache = $cache.get('hyperHttpCache');
// bust the cache for everyone
cache.remove(href);
Expand All @@ -152,13 +146,12 @@ pkg.factory('hyperHttpEmitter', [
'cache-control': 'no-cache, must-revalidate',
'pragma': 'no-cache'
},
cache: cache
cache: false
};

$http.get(href, req)
.success(function(body, status, headers) {
if (shouldNotify) subs.emit(href, body);
else emitter.refresh(href, true);
subs.emit(href, body);
})
.error(function(err) {
console.error(err.stack || err);
Expand Down