[codex] chore: require Windows verify checks#205
Merged
Conversation
What was built/changed: - Modified files: .github/workflows/verify.yml, CHANGELOG.md, TODO.md - CI behavior: Windows verify is now blocking; Linux remains best-effort with continue-on-error - Branch protection: main now requires Verify (macos-latest) and Verify (windows-latest) Why this approach: - Phase 16 proved startup smoke coverage is stable on Windows and macOS. - Keeping continue-on-error only for Ubuntu preserves Linux as best-effort while making Windows regressions block merges. - No app runtime behavior, release workflow, signing, updater, or dependency changes were made. Tested: - Confirmed the last 10 Windows verify jobs were green before promotion. - npm run verify: zero errors - npm run smoke:startup: reached http://127.0.0.1:8765/status and cleaned up the process - actionlint .github/workflows/verify.yml: passed - Branch protection required checks: Verify (macos-latest), Verify (windows-latest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes Windows Support Phase 17 CI behavior.
verify.ymlso only Ubuntu remains best-effort withcontinue-on-error.Verify (windows-latest)blocking in the workflow, matching macOS required behavior.CHANGELOG.mdandTODO.mdfor the CI policy change.Branch protection
Updated
mainbranch protection through the GitHub API before opening this PR. Required status checks are now:Verify (macos-latest)Verify (windows-latest)Strict status checks remain enabled. macOS protection is unchanged except for adding Windows alongside it.
Validation
Verify (windows-latest)jobs were green before promotion.npm run verifypassed locally on Windows.npm run smoke:startuppassed locally on Windows and reachedhttp://127.0.0.1:8765/status.8765.actionlint .github/workflows/verify.ymlpassed locally.macOS safety
This is a workflow-policy change only. No app runtime code, release workflow, signing, updater, platform adapter, or macOS behavior changed. The macOS verify job remains required.