[codex] test: add startup smoke coverage#204
Merged
Merged
Conversation
What was built/changed: - New files: tests/smoke/startup-smoke.js - Modified files: .github/workflows/verify.yml, package.json, CHANGELOG.md, TODO.md - New npm scripts: smoke:startup - New CI coverage: startup smoke step on Windows and macOS verify jobs Why this approach: - Uses the existing cross-platform startup helper with --skip-compile after repository verification has compiled the app. - Polls http://127.0.0.1:8765/status with a clear timeout and cleans up the spawned process tree. - Keeps Linux best-effort by gating the smoke step to Windows and macOS only. - Adds no new dependencies and does not change runtime updater, release, or signing behavior. Tested: - npm run verify: zero errors - npm run smoke:startup: reached http://127.0.0.1:8765/status and cleaned up the process - actionlint .github/workflows/verify.yml: passed - netstat :8765 after smoke: no listener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Windows Support Phase 16 startup smoke coverage.
tests/smoke/startup-smoke.js, a Node runner that starts Tandem throughscripts/start.js --skip-compile, pollshttp://127.0.0.1:8765/status, and cleans up the spawned process tree.npm run smoke:startup.verifyGitHub Actions matrix on Windows and macOS only; Linux remains best-effort and skips this phase's smoke step.CHANGELOG.mdandTODO.mdfor the test/CI coverage.macOS safety
The change is additive for macOS. It does not change shared app runtime behavior, release workflow behavior, signing, updater logic, or platform adapters. The same startup smoke runner now runs on macOS verify so the existing Tier 1 baseline must stay green.
Windows scope
This does not make Windows required yet. The existing workflow-level
continue-on-errorbehavior is unchanged, so Windows remains non-blocking until the later promotion phase.Validation
npm run verifypassed locally on Windows.npm run smoke:startuppassed locally on Windows and reachedhttp://127.0.0.1:8765/status.8765had no listener after smoke cleanup.actionlint .github/workflows/verify.ymlpassed locally.