Fix unexpected termination by clicking run button.#120
Open
silkycove wants to merge 1 commit intohybridgroup:masterfrom
Open
Fix unexpected termination by clicking run button.#120silkycove wants to merge 1 commit intohybridgroup:masterfrom
silkycove wants to merge 1 commit intohybridgroup:masterfrom
Conversation
Contributor
|
Just tested it out on Mac. Looks good there. Windows™ and Linux will be tested soon. |
Contributor
|
@deadprogram, do you think you could test linux? |
Member
|
I've done something to my dependencies, maybe @adzankich can verify this till I get them fixed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When TMP (default kidcode path) contains multi-byte character code, KidsRuby (Qt) fails to write kidcode.rb.
In addition, Qt::MessageBox::warning causes 'method_missing'.
Finally, KidsRuby is unexpectedly terminated by clicking Run button.
is addressed by force_encoding utf-8. 2) is addressed by passing nil instead of self.
Please review the code.