base setup for mangadex import; handling base cases#550
Open
toyhammered wants to merge 6 commits into
Open
Conversation
houndci-bot
reviewed
Aug 10, 2019
houndci-bot
reviewed
Aug 26, 2019
| RSpec.describe MangadexImport::Row do | ||
| let(:mangadex_data_regular) { JSON.parse(fixture('mangadex_import/manga-batch-1-temp.ndjson')) } | ||
| let(:mangadex_data_hentai) { JSON.parse(fixture('mangadex_import/mangadex-hentai.ndjson')) } | ||
| # let(:kitsu_data) { JSON.parse(fixture('mangadex_import/kitsu_data/kyou-wa-kaisha-yasumimasu.json')) } |
There was a problem hiding this comment.
Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
| return if mangadex_data['chapters'].blank? | ||
|
|
||
| mangadex_data['chapters'].each do |mangadex_chapter| | ||
| kitsu_chapter = kitsu_data.chapters.where(number: mangadex_chapter['chapter']).first_or_initialize |
There was a problem hiding this comment.
Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
toyhammered
commented
Aug 26, 2019
|
|
||
| mangadex_data['chapters'].each do |mangadex_chapter| | ||
| kitsu_chapter = kitsu_data.chapters.where(number: mangadex_chapter['chapter']).first_or_initialize | ||
| kitsu_chapter.volume_number ||= mangadex_chapter['volume'] |
Member
Author
There was a problem hiding this comment.
@NuckChorris Are we getting rid of volume_number and just going to be using the Volume association? Should I just find or create a new volume based on the chapter?
houndci-bot
reviewed
Sep 7, 2019
toyhammered
commented
Sep 7, 2019
| @@ -0,0 +1,34 @@ | |||
| class MangadexImport | |||
| class Chapter1 | |||
Member
Author
There was a problem hiding this comment.
@NuckChorris I am having naming conflicts with ActiveRecord Chapter. Unsure how to fix
toyhammered
commented
Sep 8, 2019
| # NOTE: I don't think this works the way I intended. | ||
| # I was thinking that we can just do save at the end and it will save | ||
| # the associations. | ||
| @kitsu_data.categories << category |
Member
Author
There was a problem hiding this comment.
This saves right away is what I realized
toyhammered
commented
Sep 8, 2019
| 'hungarian' => 'hu', | ||
| 'indonesian' => 'id_in', | ||
| 'italian' => 'it', | ||
| 'japanese' => 'en_jp', |
toyhammered
commented
Sep 8, 2019
| 'catalan' => 'ca', | ||
| 'chinese (trad)' => 'zh_Hant', | ||
| 'chinese (simp)' => 'zh_Hans', | ||
| 'english' => 'en', |
Member
Author
There was a problem hiding this comment.
should this also be en_jp because when saving with Chapter it will fail validation...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This feature will import all the data we scraped from mangadex and update our database.
This has the potential to update or create:
Why
Still in the process, but the general idea is to copy what we did for the tvdb scheduled job import.
Checklist