Skip to content
This repository was archived by the owner on Jun 26, 2022. It is now read-only.

Conversation

@tnkerer
Copy link

@tnkerer tnkerer commented Jun 6, 2022

No description provided.

"name": "counter",
"outputs": [{ "internalType": "uint256", "name": "", "type": "uint256" }],
"stateMutability": "view",
"type": "function"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not update this file unless we need to

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

package.json Outdated
"@graphprotocol/graph-cli": "0.29.2",
"@graphprotocol/graph-ts": "0.26.0"
"@graphprotocol/graph-ts": "0.26.0",
"gluegun": "^5.1.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want gluegun?

package.json Outdated
"create-local": "graph create --node http://localhost:8020/ posix4e/humansubgraph",
"remove-local": "graph remove --node http://localhost:8020/ posix4e/humansubgraph",
"deploy-local": "graph deploy --node http://localhost:8020/ --ipfs http://localhost:5001 posix4e/humansubgraph"
"deploy": "graph deploy --node https://api.thegraph.com/deploy/ menezesphill/hmtmoonbeam",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need to update this stuff. We probably should remove them altogether

Copy link
Contributor

@posix4e posix4e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some changes in the PR

@posix4e posix4e requested review from Jalal-1 and ivhus June 6, 2022 22:37
@tnkerer
Copy link
Author

tnkerer commented Jun 7, 2022

Have some changes in the PR

@posix4e I reverted ABIs back to the original from the main branch. Removed create-local, remove-local, deploy-local, and deploy scripts from package.json and removed gluegun since it is a fix unrelated to this deployment for an error that I had encountered while using yarn.

"name": "counter",
"outputs": [{ "internalType": "uint256", "name": "", "type": "uint256" }],
"stateMutability": "view",
"type": "function"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

ivhus
ivhus previously requested changes Jun 7, 2022
Copy link
Contributor

@ivhus ivhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that indicating environment variables in a way like USER_ID=239482 USER_KEY=foobar node app.js works

@ivhus ivhus dismissed their stale review June 7, 2022 15:54

Wrongly posted, confused PRs

@ivhus ivhus self-requested a review June 7, 2022 16:37
Copy link
Contributor

@ivhus ivhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy part looks fine

Not sure about package.json and such

There's a question with humanprotocol/moonbeam (https://thegraph.com/hosted-service/subgraph/humanprotocol/moonbeam):

There was no subgraph like this, I am not sure it's going to be created automatically (only the deploy to pre-created subgraph was tested before).

@tnkerer
Copy link
Author

tnkerer commented Jun 7, 2022

The deploy part looks fine

Not sure about package.json and such

There's a question with humanprotocol/moonbeam (https://thegraph.com/hosted-service/subgraph/humanprotocol/moonbeam):

There was no subgraph like this, I am not sure it's going to be created automatically (only the deploy to pre-created subgraph was tested before).

Hi @ivhus, I believe package.json is ok since workflow only uses codegen & build, these two scripts are still there.

From my experience, the subgraph is not created automatically, so I believe the deployment will only take effect if the humanprotocol/moonbeam subgraph is created in advance using the foundation account.

@posix4e
Copy link
Contributor

posix4e commented Jun 7, 2022

@ivhus i tagged you in the ticket so we could use a foundation controlled subgraph, like the other two production nets

@ivhus
Copy link
Contributor

ivhus commented Jun 8, 2022

https://thegraph.com/hosted-service/subgraph/humanprotocol/moonbeam

so I assume after the merge it should be deployed

@posix4e
Copy link
Contributor

posix4e commented Jun 8, 2022 via email

@tnkerer
Copy link
Author

tnkerer commented Jun 8, 2022

https://thegraph.com/hosted-service/subgraph/humanprotocol/moonbeam

so I assume after the merge it should be deployed

Confirmed, the repo has been created on The Graph. I think we are good to go.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants