Skip to content

Conversation

@flopez7
Copy link
Contributor

@flopez7 flopez7 commented Nov 12, 2025

Issue tracking

Close #3643

Context behind the change

  • Add APPROVE_AMOUNT to env schema in case we want to set a high value.
  • Removed old logic and cron jobs to create escrow, setup and fund. Now we use the newcreateFundAndSetupEscrow
  • Created a new method in web3.service.ts to calculate Escrow Factory allowance and approve more if needed
  • Updated web3.service.ts to use NonceManager instead of Wallet
  • Updated unit tests.

How has this been tested?

  • Ran unit tests
  • Deployed and tested locally

Release plan

New property APPROVE_AMOUNT_USD has a 100 units default value. In case we want to ad more, set it up.
Run new migrations.

Potential risks; What to monitor; Rollback plan

Check escrow creation process

@flopez7 flopez7 requested a review from portuu3 November 12, 2025 09:51
@flopez7 flopez7 self-assigned this Nov 12, 2025
@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

5 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
faucet-frontend Ignored Ignored Preview Nov 21, 2025 3:44pm
faucet-server Ignored Ignored Preview Nov 21, 2025 3:44pm
human-app Skipped Skipped Nov 21, 2025 3:44pm
human-dashboard-frontend Skipped Skipped Nov 21, 2025 3:44pm
staking-dashboard Skipped Skipped Nov 21, 2025 3:44pm

@vercel vercel bot temporarily deployed to Preview – staking-dashboard November 12, 2025 09:54 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend November 12, 2025 09:54 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app November 12, 2025 09:54 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app November 20, 2025 09:22 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend November 20, 2025 09:22 Inactive
@vercel vercel bot temporarily deployed to Preview – staking-dashboard November 20, 2025 09:22 Inactive
@flopez7 flopez7 requested a review from portuu3 November 20, 2025 09:22
@vercel vercel bot temporarily deployed to Preview – staking-dashboard November 20, 2025 13:51 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend November 20, 2025 13:51 Inactive
@flopez7 flopez7 force-pushed the feat/job-launcher/one-transaction branch from 84970b4 to cc3a188 Compare November 20, 2025 13:57
@vercel vercel bot temporarily deployed to Preview – staking-dashboard November 20, 2025 13:57 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app November 20, 2025 13:57 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend November 20, 2025 13:57 Inactive
}

get approveAmountUsd(): number {
return this.configService.get<number>('APPROVE_AMOUNT_USD', 100);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set default 0, if it is not set, then approve needs to be done manually

@vercel vercel bot temporarily deployed to Preview – staking-dashboard November 21, 2025 13:57 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend November 21, 2025 13:57 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app November 21, 2025 13:57 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app November 21, 2025 15:44 Inactive
@vercel vercel bot temporarily deployed to Preview – staking-dashboard November 21, 2025 15:44 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend November 21, 2025 15:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Job Launcher] Use 1 tx job launch

3 participants