[Job Launcher][Server] Rate limiting #3446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dzeranov
reviewed
Jul 4, 2025
Contributor
There was a problem hiding this comment.
@flopez7 looks good.
If I understand it correctly, ThrottlerGuard uses client's IP to track the number of requests, right?
But why can't we just protect our endpoints with hcaptcha guard? As far as I remember, on frontend we request users to solve captcha to send a request but it looks like we're not validating it.
packages/apps/job-launcher/server/src/modules/auth/auth.controller.ts
Outdated
Show resolved
Hide resolved
portuu3
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
https://github.com/humanprotocol/Dummy-Reports-/issues/17
Context behind the change
Add throttling support and apply to forgot password endpoint
How has this been tested?
Deployed locally and called the endpoint several times untill I received the 429 error
Release plan
None
Potential risks; What to monitor; Rollback plan
Check if the limits are set correctly.