Skip to content

feat(KVStoreModal): add useRef for smooth scrolling #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

feat(KVStoreModal): add useRef for smooth scrolling #3077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
555b3ec
feat(KVStoreModal): add useRef for smooth scrolling
flopez7 Feb 6, 2025
fa6710a
Merge branch 'develop' into feat/staking/scroll
portuu3 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/apps/staking/src/components/modals/KVStoreModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
Tooltip,
Typography,
} from '@mui/material';
import React, { useEffect, useState } from 'react';
import React, { useEffect, useState, useRef } from 'react'; // <-- Importa useRef
import { useSnackbar } from '../../providers/SnackProvider';
import BaseModal from './BaseModal';

Expand All @@ -44,6 +44,7 @@ const KVStoreModal: React.FC<Props> = ({
>([]);
const [loading, setLoading] = useState(false);
const { showError } = useSnackbar();
const formContainerRef = useRef<HTMLDivElement | null>(null);

useEffect(() => {
if (open) {
Expand All @@ -54,8 +55,7 @@ const KVStoreModal: React.FC<Props> = ({
setFormData(preparedData);
setPendingChanges([]);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [open]);
}, [open, initialData]);

const updatePendingChanges = (key: string, value: string) => {
setPendingChanges((prev) => {
Expand Down Expand Up @@ -125,6 +125,12 @@ const KVStoreModal: React.FC<Props> = ({

const handleAddField = () => {
setFormData((prev) => [...prev, { key: '', value: '' }]);

setTimeout(() => {
formContainerRef.current?.lastElementChild?.scrollIntoView({
behavior: 'smooth',
});
}, 100);
};

const handleSave = async () => {
Expand Down Expand Up @@ -169,6 +175,7 @@ const KVStoreModal: React.FC<Props> = ({
Edit KVStore
</Typography>
<Box
ref={formContainerRef}
sx={{
maxHeight: '400px',
overflowY: 'auto',
Expand Down
Loading