[Reputation Oracle] feat: get rid of sdk's storage module #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
dnechay
force-pushed
the
dnechay/2719
branch
from
2645c86 to
1665f02
Compare
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
dnechay
force-pushed
the
dnechay/2719
branch
from
1665f02 to
f4251a6
Compare
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
dnechay
commented
Nov 13, 2024
packages/apps/reputation-oracle/server/src/modules/storage/storage.service.spec.ts
Show resolved
Hide resolved
dnechay
force-pushed
the
dnechay/2719
branch
from
f4251a6 to
1a229b3
Compare
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
dnechay
changed the title
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
dnechay
force-pushed
the
dnechay/2719
branch
from
14efdef to
3d84741
Compare
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
Dzeranov
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
Resolves #2719
Context behind the change
Storage module in SDK is going to be deprecated, so we get rid of it here. At the same time existing storage utils have a bug in working with binaries: when doing
copyFileFromURLToBucketit's being downloaded as string instead of binary (which is expected to be a.zip) and it leads to file in invalid format being copied; this PR also fixed that.How has this been tested?
copyFileFromURLToBucketfor some encrypted.zipfile and make sure it's copied to proper bucket;.zipfile that can openedRelease plan
Merge & deploy as is.
Only open question is if we need to fix some files that already uploaded as string instead of zip?!
Potential risks; What to monitor; Rollback plan
Can't think of any