[Job Launcher] - Proper testing and documentation updates (#664)

* Added logic for rate processing

* Updated tests

* Updated transaction amount converting

* Updated get balance method, added unsupported token test case, updated tests

* Fixed comparison of balance and fund amount and unit tests

* Added recipient validation and updated unit tests (#669)

* Removed dublicate return

* Updated get rate method to work with tokens and cirrencies

* Resolved conflicts

* Updated payment service

* Updated fund amount calculation

* suggest fee management in job launcher (#692)

* Fixed test cases

* fix payment amount saved

* Updated unit tests

* Updated units

* Updated auth service test

* Reverted updates for unit tests

* Removed final amount count dublicates

---------

Co-authored-by: portuu3 <[email protected]>
Co-authored-by: portuu3 <[email protected]>

Author: 0xVoronov

packages/apps/job-launcher/server/src/common/constants/errors.ts

@@ -55,11 +55,12 @@ export enum ErrorPayment {
   CustomerNotFound = 'Customer not found',
   CustomerNotCreated = 'Customer not created',
   IncorrectAmount = 'Incorrect amount',
-  TransactionHashAlreadyExists = 'transaction hash already exists',
+  TransactionHashAlreadyExists = 'Transaction hash already exists',
   TransactionNotFoundByHash = 'Transaction not found by hash',
   InvalidTransactionData = 'Invalid transaction data',
   TransactionHasNotEnoughAmountOfConfirmations = 'Transaction has not enough amount of confirmations',
   UnsupportedToken = 'Unsupported token',
+  InvalidRecipient = 'Invalid recipient',
 }
 
 /**

packages/apps/job-launcher/server/src/common/constants/payment.ts

@@ -1,3 +1,3 @@
 export const CoingeckoTokenId: ICoingeckoTokenId = {
-    'hmt': 'human-protocol',
-}
+  hmt: 'human-protocol',
+};

packages/apps/job-launcher/server/src/common/interfaces/payment.ts

@@ -1,3 +1,3 @@
 interface ICoingeckoTokenId {
-    [key: string]: string;
-}
+  [key: string]: string;
+}

packages/apps/job-launcher/server/src/common/test/constants.ts

@@ -2,7 +2,7 @@ export const MOCK_REQUESTER_TITLE = 'Mock job title';
 export const MOCK_REQUESTER_DESCRIPTION = 'Mock job description';
 export const MOCK_FORTUNES_REQUIRED = 5;
 export const MOCK_CHAIN_ID = 1;
-export const MOCK_ADDRESS = '0x1234567890abcdef';
+export const MOCK_ADDRESS = '0x1234567890123456789012345678901234567892';
 export const MOCK_FILE_URL = 'mockedFileUrl';
 export const MOCK_FILE_HASH = 'mockedFileHash';
 export const MOCK_FILE_KEY = 'manifest.json';

packages/apps/job-launcher/server/src/modules/auth/auth.service.ts

@@ -102,8 +102,12 @@ export class AuthService {
     const refreshToken = v4();
     const date = new Date();
 
-    const accessTokenExpiresIn = ~~this.configService.get<number>(ConfigNames.JWT_ACCESS_TOKEN_EXPIRES_IN)!;
-    const refreshTokenExpiresIn = ~~this.configService.get<number>(ConfigNames.JWT_REFRESH_TOKEN_EXPIRES_IN)!;
+    const accessTokenExpiresIn = ~~this.configService.get<number>(
+      ConfigNames.JWT_ACCESS_TOKEN_EXPIRES_IN,
+    )!;
+    const refreshTokenExpiresIn = ~~this.configService.get<number>(
+      ConfigNames.JWT_REFRESH_TOKEN_EXPIRES_IN,
+    )!;
 
     await this.logout({ userId: userEntity.id });
 

packages/apps/job-launcher/server/src/modules/job/job.dto.ts

@@ -146,9 +146,6 @@ export class FortuneManifestDto {
   @IsString()
   requesterDescription: string;
 
-  @IsString()
-  fee: string;
-
   @IsString()
   fundAmount: string;
 
@@ -174,9 +171,6 @@ export class ImageLabelBinaryManifestDto {
   @IsPositive()
   requesterAccuracyTarget: number;
 
-  @IsString()
-  fee: string;
-
   @IsString()
   fundAmount: string;