[Fortune] [Exchange oracle] Get manifest data from reputation oracle (#691)

* exchange oracle - get manifest data from reputation oracle

* fix kvstore key

* use env variable for reputation oracle url

* revert sdk change

Author: 0xadev7

packages/apps/fortune/exchange-oracle/server/src/common/config/env.ts

@@ -4,6 +4,7 @@ export const ConfigNames = {
   HOST: 'HOST',
   PORT: 'PORT',
   WEB3_PRIVATE_KEY: 'WEB3_PRIVATE_KEY',
+  REPUTATION_ORACLE_URL: 'REPUTATION_ORACLE_URL',
 };
 
 export const envValidator = Joi.object({

packages/apps/fortune/exchange-oracle/server/src/modules/job/job.controller.spec.ts

@@ -1,3 +1,4 @@
+import { ConfigService } from '@nestjs/config';
 import { Test } from '@nestjs/testing';
 import { JobController } from './job.controller';
 import { JobService } from './job.service';
@@ -14,11 +15,20 @@ describe('JobController', () => {
   const escrowAddress = '0x1234567890123456789012345678901234567890';
   const workerAddress = '0x1234567890123456789012345678901234567891';
 
+  const reputationOracleURL = 'https://example.com/reputationoracle';
+  const configServiceMock = {
+    get: jest.fn().mockReturnValue(reputationOracleURL),
+  };
+
   beforeAll(async () => {
     const moduleRef = await Test.createTestingModule({
       controllers: [JobController],
       providers: [
         JobService,
+        {
+          provide: ConfigService,
+          useValue: configServiceMock,
+        },
         {
           provide: Web3Service,
           useValue: {

packages/apps/fortune/exchange-oracle/server/src/modules/job/job.module.ts

@@ -1,11 +1,12 @@
 import { Module } from '@nestjs/common';
+import { ConfigModule } from '@nestjs/config';
 import { JobController } from './job.controller';
 import { JobService } from './job.service';
 import { HttpModule } from '@nestjs/axios';
 import { Web3Module } from '../web3/web3.module';
 
 @Module({
-  imports: [HttpModule, Web3Module],
+  imports: [ConfigModule, HttpModule, Web3Module],
   controllers: [JobController],
   providers: [JobService],
 })

packages/apps/fortune/exchange-oracle/server/src/modules/job/job.service.spec.ts

@@ -1,13 +1,10 @@
 import { HttpService } from '@nestjs/axios';
+import { ConfigService } from '@nestjs/config';
 import { Test } from '@nestjs/testing';
 import { of } from 'rxjs';
 import { Web3Service } from '../web3/web3.service';
 import { JobService } from './job.service';
-import {
-  EscrowClient,
-  KVStoreClient,
-  StorageClient,
-} from '@human-protocol/sdk';
+import { EscrowClient, KVStoreClient } from '@human-protocol/sdk';
 
 jest.mock('@human-protocol/sdk', () => ({
   ...jest.requireActual('@human-protocol/sdk'),
@@ -27,8 +24,10 @@ jest.mock('axios', () => ({
 }));
 
 describe('JobService', () => {
+  let configService: ConfigService;
   let jobService: JobService;
   let web3Service: Web3Service;
+  let httpService: HttpService;
 
   const chainId = 1;
   const escrowAddress = '0x1234567890123456789012345678901234567890';
@@ -39,6 +38,11 @@ describe('JobService', () => {
     getNetwork: jest.fn().mockResolvedValue({ chainId: 1 }),
   };
 
+  const reputationOracleURL = 'https://example.com/reputationoracle';
+  const configServiceMock = {
+    get: jest.fn().mockReturnValue(reputationOracleURL),
+  };
+
   const httpServicePostMock = jest
     .fn()
     .mockReturnValue(of({ status: 200, data: {} }));
@@ -47,6 +51,10 @@ describe('JobService', () => {
     const moduleRef = await Test.createTestingModule({
       providers: [
         JobService,
+        {
+          provide: ConfigService,
+          useValue: configServiceMock,
+        },
         {
           provide: Web3Service,
           useValue: {
@@ -57,13 +65,18 @@ describe('JobService', () => {
           provide: HttpService,
           useValue: {
             post: httpServicePostMock,
+            axiosRef: {
+              get: jest.fn(),
+            },
           },
         },
       ],
     }).compile();
 
+    configService = moduleRef.get<ConfigService>(ConfigService);
     jobService = moduleRef.get<JobService>(JobService);
     web3Service = moduleRef.get<Web3Service>(Web3Service);
+    httpService = moduleRef.get<HttpService>(HttpService);
   });
 
   describe('getDetails', () => {
@@ -74,14 +87,10 @@ describe('JobService', () => {
         fortunesRequested: 5,
         fundAmount: 100,
       };
-      (EscrowClient.build as any).mockImplementation(() => ({
-        getManifestUrl: jest
-          .fn()
-          .mockResolvedValue('https://example.com/manifest.json'),
-      }));
-      (StorageClient.downloadFileFromUrl as any).mockResolvedValue({
-        ...manifest,
-        fortunesRequired: manifest.fortunesRequested,
+
+      httpService.axiosRef.get = jest.fn().mockResolvedValue({
+        status: 200,
+        data: { ...manifest, fortunesRequired: manifest.fortunesRequested },
       });
 
       const result = await jobService.getDetails(chainId, escrowAddress);
@@ -91,37 +100,14 @@ describe('JobService', () => {
         chainId,
         manifest,
       });
-      expect(web3Service.getSigner).toHaveBeenCalledWith(chainId);
     });
 
-    it('should fail if the escrow address is invalid', async () => {
-      const escrowAddress = 'invalid_address';
-      (EscrowClient.build as any).mockImplementation(() => ({
-        getManifestUrl: jest
-          .fn()
-          .mockRejectedValue(new Error('Invalid address')),
-      }));
+    it('should fail if reputation oracle url is empty', async () => {
+      configService.get = jest.fn().mockReturnValue('');
 
       await expect(
         jobService.getDetails(chainId, escrowAddress),
-      ).rejects.toThrow('Invalid address');
-      expect(web3Service.getSigner).toHaveBeenCalledWith(chainId);
-    });
-
-    it('should fail if the file does not exist', async () => {
-      (EscrowClient.build as any).mockImplementation(() => ({
-        getManifestUrl: jest
-          .fn()
-          .mockResolvedValue('https://example.com/manifest.json'),
-      }));
-      (StorageClient.downloadFileFromUrl as any).mockRejectedValue(
-        new Error('File not found'),
-      );
-
-      await expect(
-        jobService.getDetails(chainId, escrowAddress),
-      ).rejects.toThrow('File not found');
-      expect(web3Service.getSigner).toHaveBeenCalledWith(chainId);
+      ).rejects.toThrow('Unable to get Reputation Oracle URL');
     });
   });
 

packages/apps/fortune/exchange-oracle/server/src/modules/job/job.service.ts

@@ -3,10 +3,11 @@ import {
   EscrowStatus,
   KVStoreClient,
   KVStoreKeys,
-  StorageClient,
 } from '@human-protocol/sdk';
 import { HttpService } from '@nestjs/axios';
 import { Inject, Injectable, Logger } from '@nestjs/common';
+import { ConfigService } from '@nestjs/config';
+import { ConfigNames } from '../../common/config';
 import { Web3Service } from '../web3/web3.service';
 import { JobDetailsDto } from './job.dto';
 
@@ -18,6 +19,7 @@ export class JobService {
   } = {};
 
   constructor(
+    private readonly configService: ConfigService,
     @Inject(Web3Service)
     private readonly web3Service: Web3Service,
     private readonly httpService: HttpService,
@@ -27,10 +29,19 @@ export class JobService {
     chainId: number,
     escrowAddress: string,
   ): Promise<JobDetailsDto> {
-    const signer = this.web3Service.getSigner(chainId);
-    const escrowClient = await EscrowClient.build(signer);
-    const manifestUrl = await escrowClient.getManifestUrl(escrowAddress);
-    const manifest = await StorageClient.downloadFileFromUrl(manifestUrl);
+    const reputationOracleURL = this.configService.get(
+      ConfigNames.REPUTATION_ORACLE_URL,
+    );
+
+    if (!reputationOracleURL)
+      throw new Error('Unable to get Reputation Oracle URL');
+
+    const manifest = await this.httpService.axiosRef
+      .get<any>(
+        reputationOracleURL +
+          `/manifest?chainId=${chainId}&escrowAddress=${escrowAddress}`,
+      )
+      .then((res) => res.data);
 
     return {
       escrowAddress,